Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Replacing comment assignments with a mentions-like UI #4386

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wes-otf
Copy link
Contributor

@wes-otf wes-otf commented Feb 7, 2025

This is a proof of concept of replacing the current Assign To interface with something that is potentially a little more intuitive and allows multiple users to be mentioned in the same comment with context.

Being that this is more of a PoC there is lots of sloppier code that needs to be fixed, along with edge cases to handle to don't look too hard just yet. I more just wanted to open this for discussion before any more work was done on it. Lots of notes were taken from Github, Signal & this blog post

Staff have mentioned multiple users being assigned to the same comment would be nice and they take lots of meeting notes in comments so being able to contextualize why user(s) got assigned could be beneficial

Next steps if we decide to move forward with this:

  • Move more vanilla comment_form JS logic into alpine
  • Ensure staff can't accidentally leak PII via changing comment visibility to non-staff
  • Handle staff changing email addresses
  • Adding unit tests
  • Mentioning formatting to also appear on the user's My Tasks

Demo

Screen.Recording.2025-02-07.at.14.54.35.mov

Test Steps

@wes-otf wes-otf added the Type: Feature This is something new (not an enhancement of an existing thing). label Feb 7, 2025
@wes-otf
Copy link
Contributor Author

wes-otf commented Feb 7, 2025

would love to hear any thoughts @frjo @theskumar @sandeepsajan0!

@frjo
Copy link
Member

frjo commented Feb 7, 2025

The UI looks neat!

Some nit picking around workflow and language:

Being "assigned" and that becoming a task seems logical to me. Someone "mentioning" me and I get a task less so.

If more than one person is "mentioned" who is responsible for the task?

Maybe OTF does not see this being used to hand out actual tasks? Perhaps more of mention people and they getting notified?

I think it would be better to have "tasks" be only actual tasks, things you need to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature This is something new (not an enhancement of an existing thing).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants