Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds a test to verify Action logic and removes the null check, fixes … #684

Closed
wants to merge 1 commit into from
Closed

Adds a test to verify Action logic and removes the null check, fixes … #684

wants to merge 1 commit into from

Conversation

stalep
Copy link
Member

@stalep stalep commented Sep 28, 2023

…#642

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@jesperpedersen jesperpedersen added the type/bug Something isn't working label Sep 29, 2023
@jesperpedersen
Copy link
Collaborator

@johnaohara WDYT ? I'm ok with this PR now

@jesperpedersen
Copy link
Collaborator

Rebased, and merged.

Thanks for your contribution !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jesperpedersen jesperpedersen Awaiting requested review from jesperpedersen

@johnaohara johnaohara Awaiting requested review from johnaohara

Assignees

@stalep stalep

Labels
type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stalep @jesperpedersen