-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNS - I2C ToF #26
SNS - I2C ToF #26
Conversation
Datasheet available here for the VL6180V1 ToF Sensor: https://www.st.com/en/imaging-and-photonics-solutions/vl6180.html#overview |
A lot of these functions were implemented using the 'example code' provided in the VL6180 application sheet: https://www.st.com/resource/en/application_note/an4545-vl6180x-basic-ranging-application-note-stmicroelectronics.pdf TODO:
|
Tests are failing though, not sure why
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very nearly done now! The tests aren't working properly (not sure why). A few comments here to fix and think about the API. Apart from those functionality points, would be good to add Rust doc comments to all of your functions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. i didn't read the datasheet so haven't commented on correctness stuff there
2 things:
- in general i think you should rename the "tof"s in file names and code to be "time_of_flight", just for sake of clarity.
- a lot of the
TimeOfFlight
impl methods are kinda unclear on what they do, so there's probably better names for them or if not add doc comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks very good, couple of notes
initial commit for time of flight sensor code, hope the folder structure is okay