Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNS-Gyroscope #82
base: master
Are you sure you want to change the base?
SNS-Gyroscope #82
Changes from 11 commits
20d1e51
895097c
3cb7643
5f7fbc9
c246add
99e4927
5244163
1ebe8d9
f3c35e8
568db5f
c163bc6
b2a0e6e
24ba279
e4f1a3b
ff664bd
99c6aba
ed1aa15
91d7bcc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this should probably be restructured to have a
readAxis
helper function and maybe pass inkDataXHigh
andkDataXLow
as parameters, right now this is a lot of almost duplicate code.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know we usually use full names when in doubt but
kConfigurationSetting1
seems quite verbose. Could we shorten this tokConfigSetting1
since don't think this harms readability as it is a common abbreviation?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment what these configuration values are doing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also remove the
static
since it isn't actually helping much with const valuesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still explicitly call
static
? @SnickeyXThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes here its necessary, else
create
will not be able to access gyroscope specifc functions