Fix the notification URL to chat posts #218
Merged
+26
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean up notification post URLs a lot
| @@ -434,7 +427,7 @@ module.exports = bookshelf.Model.extend({ | |||
| post_title: decode(post.title() || ''), | |||
| post_topic: firstTag, | |||
| post_type: post.get('type'), | |||
| post_url: Frontend.Route.tokenLogin(reader, token, this.postUrlHelper({ post, isPublic: false, topic: firstTag, group }) + '?ctt=post_email&cti=' + reader.id), | |||
| post_url: Frontend.Route.tokenLogin(reader, token, Frontend.Route.post(post, group, 'ctt=post_email&cti=' + reader.id)), | |||
There was a problem hiding this comment.
Do you think this fixes #183 ?
There was a problem hiding this comment.
hmm, i doubt it, that sounds like a front end issue. but its not happening for me on dev
| const tags = post.relations.tags | ||
| const firstTopic = tags && tags.first()?.get('name') | ||
| if (firstTopic && (post.get('type') === Post.Type.CHAT || group.hasChatFor(firstTopic))) { | ||
| return url(`/groups/${groupSlug}/chat/${firstTopic}?postId=${post.id}&${extraParams}`) |
There was a problem hiding this comment.
Is the main update needed for mobile that it needs to track /chat/ related urls?
There was a problem hiding this comment.
Ok, I have that in a current branch
|
we need this on staging so im going to merge now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up notification post URLs a lot. Move all of it to Frontend.Route.post
Note, these URLs will have to be updated on mobile