-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add calendar feature #178
base: dev
Are you sure you want to change the base?
Add calendar feature #178
Conversation
… into add-calendar-feature
… into add-calendar-feature
sloppy git rebase of dev branch ... agh |
Ok, lets touch on this in product and see what the crew thinks. Any changes that comes out of a product discussion we'd cover in a separate, probably pretty small, ticket. |
Thank you so much, for this! So awesome to have a plush calendar view! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
is this still a Draft Kevin, or is it really ready for review and testing? |
a Draft PR means its not really ready for review |
Ready for review -- although still working on some things like multiple days (interval) posts. |
To be clear, this version of the calendar is good enough for now, to test and potentially merge into dev. Currently:
|
I think, ok to just hide this when viewMode === 'calendar'
proposal type posts also can have start and end times. |
I agree, and tried this, but the viewmode buttons would move all the way to the left, which can be annoying if the calendar button is hit by accident or someone is wanting to see what the different viewmodes do. There may be some way to nail down the position of the viewmode buttons so they don't move laterally.
Good point, I also show calendar viewmode option for proposals, so all good there. |
I'm hiding it now -- I think it looks okay now that the calendar fills the main view space. 👍🏼 |
doing some testing. |
bug 2: it seems that no events appear on the calendar unless I first select "past" events and then switch to the calendar. it should ignore the timeframe param when on calendar view mode |
feature desire: it feels moderately important to show events that span multiple days as doing that. is that possible with this component? |
other than that its looking good! |
I'll be happy to be assigned this as a separate ticket, since this happens for ALL views when using "esc" to close the event. Clicking the "X" works as expected, so this is not related to the calendar feature.
Oooh ... good one. I'll fix this.
Agreed, and I'd like to do this after fixing bug 2 and merging into dev. For now, I'll find an elegant way to show multi-day events. I also need to show "more ..." when there's more events than can be displayed in the calendar. |
Bug 2 is fixed and I'm exploring different ways to show multi-day events. I'll commit to adding this feature asap. Another bug I'm working on now is when adding a new event, it doesn't show on the calendar until refreshing the browser. I'll fix this one next. [Update: I may need help with this one, as the other viewmodes are showing the new event without refresh, but not calendar viewmode May I merge now and work on that feature over the next two weeks? |
closes #57
Ready for review - complete for now