Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: HRN 598 (2): Scroll to Post Comment Path (keep comment component dumb) #656

Draft
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

thomasgwatson
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Patch coverage: 9.37% and project coverage change: -0.15% ⚠️

Comparison is base (259ddb2) 48.44% compared to head (6770e71) 48.30%.
Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #656      +/-   ##
==========================================
- Coverage   48.44%   48.30%   -0.15%     
==========================================
  Files         411      412       +1     
  Lines        7076     7097      +21     
  Branches     1945     1950       +5     
==========================================
  Hits         3428     3428              
- Misses       3648     3669      +21     
Files Changed Coverage Δ
src/components/Comment/Comment.js 0.00% <ø> (ø)
src/components/Comments/Comments.js 0.00% <0.00%> (ø)
src/components/FeedList/FeedList.js 8.69% <ø> (+0.36%) ⬆️
src/screens/PostDetails/PostDetails.js 78.37% <ø> (ø)
src/store/models/Notification.js 35.41% <0.00%> (ø)
src/util/findComment.js 0.00% <0.00%> (ø)
src/util/navigation.js 9.18% <33.33%> (ø)
...reens/NotificationsList/NotificationsList.store.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lorenjohnson lorenjohnson changed the title DRAFT: Hrn 598 keep comment component dumb HRN 598: Scroll to Post Comment Path (keep comment component dumb) Sep 7, 2023
@lorenjohnson lorenjohnson changed the title HRN 598: Scroll to Post Comment Path (keep comment component dumb) DRAFT: HRN 598: Scroll to Post Comment Path (keep comment component dumb) Sep 7, 2023
@lorenjohnson lorenjohnson changed the title DRAFT: HRN 598: Scroll to Post Comment Path (keep comment component dumb) (DRAFT) HRN 598: Scroll to Post Comment Path (keep comment component dumb) Sep 9, 2023
@lorenjohnson lorenjohnson changed the title (DRAFT) HRN 598: Scroll to Post Comment Path (keep comment component dumb) (DRAFT 2) HRN 598: Scroll to Post Comment Path (keep comment component dumb) Sep 9, 2023
@lorenjohnson lorenjohnson changed the title (DRAFT 2) HRN 598: Scroll to Post Comment Path (keep comment component dumb) DRAFT: HRN 598 (2): Scroll to Post Comment Path (keep comment component dumb) Jun 19, 2024
@lorenjohnson lorenjohnson marked this pull request as draft October 3, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant