Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add halo2 verifier with custom algorithm #23

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

guha-rahul
Copy link
Contributor

@guha-rahul guha-rahul commented Jun 30, 2024

addresses #11 ,
I have added the halo2 verifier in this repo using https://github.com/axiom-crypto/halo2-scaffold as a reference.

@wraitii
Copy link
Member

wraitii commented Jul 2, 2024

Hey @guha-rahul , can you clarify how to use this ?

@guha-rahul
Copy link
Contributor Author

guha-rahul commented Jul 4, 2024

Hey @guha-rahul , can you clarify how to use this ?
Sorry for the late reply
Assuming we have all the artifacts, it is supposed to cargo run main -- --name some_algorithm_in_zk -k <DEGREE> verify

@guha-rahul
Copy link
Contributor Author

@wraitii hey there, would love to hear further directions on this.

@wraitii
Copy link
Member

wraitii commented Jul 22, 2024

@wraitii hey there, would love to hear further directions on this.

I guess my question extends to "what do you mean by 'assuming we have all the artifacts' ?
Regardless, I'll proceed with validating your contribution on OD

@guha-rahul
Copy link
Contributor Author

I guess my question extends to "what do you mean by 'assuming we have all the artifacts' ?

Afai understand we need the proof, the circuit, and the vkey for the proof verification as artifacts.
Also even if i may not be eligible for rewards on this issue , i am looking forward to learn from this and hopefully get it merged .

Copy link
Member

@wraitii wraitii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gonna approve this to get you paid on OD, we'll need to restart some work on the main repo after our protocol upgrades

@wraitii wraitii merged commit 116c1fe into Hyle-org:main Aug 5, 2024
@guha-rahul
Copy link
Contributor Author

@wraitii by the main repo do you mean https://github.com/Hyle-org/hyle ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants