Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DIA-1627: Support user context in LD #6685

Merged
merged 3 commits into from
Nov 19, 2024
Merged

feat: DIA-1627: Support user context in LD #6685

merged 3 commits into from
Nov 19, 2024

Conversation

niklub
Copy link
Collaborator

@niklub niklub commented Nov 19, 2024

Extended get_user_repr() method to override LD context in LSE

Copy link

sentry-io bot commented Nov 19, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: label_studio/core/feature_flags/base.py

Function Unhandled Issue
all_flags AttributeError: 'NoneType' object has no attribute 'email' /p...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 80b1d11
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/673c710b525d1100084acab1

Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 80b1d11
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/673c710b36d6ec0008c5fdd4

@github-actions github-actions bot added the feat label Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.77%. Comparing base (fc49438) to head (80b1d11).
Report is 18 commits behind head on develop.

Files with missing lines Patch % Lines
label_studio/core/feature_flags/utils.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6685   +/-   ##
========================================
  Coverage    76.76%   76.77%           
========================================
  Files          169      170    +1     
  Lines        13865    13868    +3     
========================================
+ Hits         10644    10647    +3     
  Misses        3221     3221           
Flag Coverage Δ
pytests 76.77% <92.85%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@niklub niklub removed the request for review from makseq November 19, 2024 13:04
@niklub niklub merged commit 2922013 into develop Nov 19, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants