Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: OPTIC-1045: Update default placeholder text used in task data to be more clear #6656

Merged
merged 5 commits into from
Nov 19, 2024

Conversation

bmartel
Copy link
Contributor

@bmartel bmartel commented Nov 14, 2024

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

The default placeholder text used with our Labelling configs in the Preview are often distracting and not clearly obvious that it is just sample data. This updates those which were containing non-obvious text to be clearly sample text.

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

Which logical domain(s) does this change affect?

Label Config Preview, Sample Task Data

@github-actions github-actions bot added the fix label Nov 14, 2024
Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit fa03891
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/673b4e32eac1790008f8f96e

Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit fa03891
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/673b4e322861fe0008471f9c

@MihajloHoma
Copy link
Contributor

MihajloHoma commented Nov 18, 2024

/git merge

Workflow run
Successfully merged: create mode 100644 web/libs/ui/src/lib/Toast/Toast.tsx

@robot-ci-heartex
Copy link
Collaborator

Follow Merge downstream workflow has been failed.

Workflow run

@bmartel
Copy link
Contributor Author

bmartel commented Nov 18, 2024

/git merge develop

Workflow run
Successfully merged: 6 files changed, 9 insertions(+), 9 deletions(-)

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.76%. Comparing base (fc49438) to head (fa03891).
Report is 21 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6656   +/-   ##
========================================
  Coverage    76.76%   76.76%           
========================================
  Files          169      169           
  Lines        13865    13865           
========================================
  Hits         10644    10644           
  Misses        3221     3221           
Flag Coverage Δ
pytests 76.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@bmartel bmartel merged commit 53c3cf9 into develop Nov 19, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants