feat: LEAP-1492: More flexible Custom buttons #6454
+92
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- extend the structure of custom buttons definition to allow different modes - custom buttons now can replace just some buttons, leaving the rest untouched - start to simplify work with all buttons to use standard button description + additional wrappers for main actions, so any button action will go through mandatory checks
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
Gondragos
reviewed
Oct 2, 2024
Comment on lines
+33
to
+35
| function toArray<T>(arg: undefined | T | (T | undefined)[]): T[] { | ||
| return (Array.isArray(arg) ? arg : [arg]).filter(v => v !== undefined); | ||
| } |
There was a problem hiding this comment.
It could be moved to utils
Gondragos
reviewed
Oct 2, 2024
| await onClick?.(button.name); | ||
| setWaiting(false); | ||
| }, []); | ||
| // @todo do we need waiting? all buttons should utilize isSubmitting |
There was a problem hiding this comment.
It's for indication, but it may look not good.
Gondragos
reviewed
Oct 2, 2024
|
|
||
| // either we render _before buttons and then the rest, or we render only _replace buttons | ||
| if (firstToRender) { | ||
| const allButtons = Array.isArray(firstToRender) ? firstToRender : [firstToRender]; |
There was a problem hiding this comment.
Suggested change
| const allButtons = Array.isArray(firstToRender) ? firstToRender : [firstToRender]; | |
| const allButtons = toArray(firstToRender); |
Gondragos
reviewed
Oct 2, 2024
Gondragos
reviewed
Oct 2, 2024
| @@ -29,7 +29,8 @@ type MSTCommentStore = { | |||
| }; | |||
|
|
|||
| type MSTStore = { | |||
| customButtons: Instance<typeof CustomButton>[]; | |||
| // @todo we can't import CustomButton store here and use it type :( | |||
| customButtons: any; | |||
There was a problem hiding this comment.
I've just figured out that it works for me 🤯
Suggested change
| customButtons: any; | |
| customButtons: CustomControlProps.button[]; |
Gondragos
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Examples of new structure:
PR fulfills these requirements
Change has impacts in these area(s)
Describe the reason for change
We need to dynamically display buttons we need, so previous predefined approach didn't work.
Does this change affect performance?
no
Does this change affect security?
no
What alternative approaches were there?
(briefly list any if applicable)
Does this PR introduce a breaking change?
What level of testing was included in the change?