-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add region:visibility-all shortcut (ctrl+h) #6212
base: develop
Are you sure you want to change the base?
Conversation
👷 Deploy request for label-studio-docs-new-theme pending review.Visit the deploys page to approve it
|
👷 Deploy request for heartex-docs pending review.Visit the deploys page to approve it
|
3b4406f
to
2d2ef63
Compare
f55326b
to
39efce4
Compare
I reverted my changes made to web/dist, no idea if that's what's expected |
Hello! Would it be possible to review this PR? I tried to make it as small and as little as possible to ease review. Thanks! |
Up! @hlomzik maybe? |
Up! I'm trying with @yyassi-heartex this time |
/jira create
|
Oh, thank you for patience and for this contribution, @LouisJULIEN ! |
Hey @hlomzik , thanks for running the CI. Is everything good? |
up @hlomzik |
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made
ex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
Change has impacts in these area(s)
(check all that apply)
Describe the reason for change
(link to issue, supportive screenshots etc.)
No shortcut existed to hide all regions. It had to be done through a click tot he dedicated button on the sidebar
What does this fix?
(if this is a bug fix)
What is the new behavior?
(if this is a breaking or feature change)
by default, ctrl+h now hide all regions if one is visible. If none is visible, it show all regions.
What is the current behavior?
(if this is a breaking or feature change)
ctrl + h has no behavior on label studio.
What libraries were added/updated?
(list all with version changes)
None
Does this change affect performance?
(if so describe the impacts positive or negative)
No
Does this change affect security?
(if so describe the impacts positive or negative)
No
What alternative approaches were there?
(briefly list any if applicable)
Click on the sidebar button
What feature flags were used to cover this change?
(briefly list any if applicable)
None
Does this PR introduce a breaking change?
(check only one)
What level of testing was included in the change?
(check all that apply)
Does manual testing counts for a shortcut (I kind of hate myself for asking)?
Which logical domain(s) does this change affect?
(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)