Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sam2 #663

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

fix: sam2 #663

wants to merge 10 commits into from

Conversation

micaelakaplan
Copy link
Collaborator

Sam2 was updated in it's folder structure HERE which broke our integration. Fixed in this PR

@micaelakaplan micaelakaplan changed the title update for breaking sam2 changes fix: sam2 Nov 5, 2024
@guajun
Copy link

guajun commented Nov 13, 2024

There are typos of bash cmd in README. See this

@brunodoamaral
Copy link

I'd like to suggest to update the Dockerfile and compose. Here is what I did:

brunodoamaral@2ce8317

@micaelakaplan
Copy link
Collaborator Author

There are typos of bash cmd in README. See this

fixed! thanks for pointing this out!

@micaelakaplan
Copy link
Collaborator Author

I'd like to suggest to update the Dockerfile and compose. Here is what I did:

brunodoamaral@2ce8317

@niklub is there a reason we shouldn't merge this change as well?

@brunodoamaral
Copy link

I'd like to suggest to update the Dockerfile and compose. Here is what I did:
brunodoamaral@2ce8317

@niklub is there a reason we shouldn't merge this change as well?

mamba install is way faster than conda install.
Another reason is that Miniconda is distributed by Anaconda, which has a restrictive license. So I suggest updating the PyTorch docker image to at least 2.4.1, which changed to Miniforge (see: https://github.com/pytorch/pytorch/releases/v2.4.1).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants