Docker set up to support reading checkpoint_file from config.json and documentation #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…json, resolves missing configuration in _wsgi.py.tml and updates README.md for docker set up instructions
farioas
approved these changes
Sep 23, 2021
makseq
reviewed
Sep 23, 2021
| @@ -15,7 +15,9 @@ COPY supervisord.conf /etc/supervisor/conf.d/ | |||
|
|
|||
| WORKDIR /app | |||
|
|
|||
| COPY /models/*.pt /app/data/models/ | |||
There was a problem hiding this comment.
@ntlex What if /models doesn't exist? Looks like it's a very user/system specific folder.
There was a problem hiding this comment.
You are right, I could remove this line since it is elaborated in the the README.md to ensure that the user either has to volumize or copy the model dir in the docker application.
There was a problem hiding this comment.
maybe it's better to check existence of this folder? and then COPY it
There was a problem hiding this comment.
I think I misunderstood your initial comment about the user specific directory. I have corrected the directory's path to ./models/*.pt on the latest commit. Let me know if this is what you had in mind.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Created a PR to support passing the model's checkpoint_files in a docker container set up. Here's a sort description of the changes:
label_studio_ml/default_configs/_wsgi.py.tmplthere is support for reading thecheckpoint_filethroughconfig.json(see methodget_kwargs_from_config()) thejsonimport is missing as well as making the kwargs available to theuWSGIapp.config.jsonin thedefault_configsDockerfileto copy theconfig.jsonas well as thecheckpoint_filethat should be placed in./models/README.mdwith the instructions on using the backend with docker, including considering the cloud storage credentials and checkpoint file exposure