This repository has been archived by the owner on Apr 18, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 44
fix: LSDV-4864: LEAP-148: Magic Wand doesn't work with MIG #175
Open
nicholasrq
wants to merge
5
commits into
master
Choose a base branch
from
fb-lsdv-4864/magic-wand-mig
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlomzik
approved these changes
Apr 26, 2023
bmartel
suggested changes
Apr 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, just one small change.
bmartel
approved these changes
Apr 26, 2023
nicholasrq
changed the title
fix: LSDV-4864: Magic Wand doesn't work with MIG
fix: LSDV-4864: LEAP-148: Magic Wand doesn't work with MIG
Jan 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is a minor lint error, other wise approved
Co-authored-by: yyassi-heartex <[email protected]>
yyassi-heartex
approved these changes
Jan 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support asynchronous LSF serialization, it's used for Magic Wand serialization, based on dataURL.
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made
ex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
Change has impacts in these area(s)
(check all that apply)
Describe the reason for change
LSDV-4864
What does this fix?
Fixes inability to use the Magic Wand when image preloading is enabled. It uses async serialization, so all lsf-sdk methods should be ready for this.
What is the new behavior?
Magic Wand works with image preloading enabled
What is the current behavior?
Magic Wand doesn't work when the image preloading is enabled
What libraries were added/updated?
None
Does this change affect performance?
No
Does this change affect security?
No
What alternative approaches were there?
None
What feature flags were used to cover this change?
fflag_feat_front_dev_4081_magic_wand_tool
fflag_feat_front_lsdv_4583_6_images_preloading_short
Does this PR introduce a breaking change?
(check only one)
What level of testing was included in the change?
(check all that apply)
Which logical domain(s) does this change affect?
Labeling Interface, Image Segmentation, Magic Wand