Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DIA-977: Get streaming job status #97

Merged
merged 31 commits into from
Apr 24, 2024
Merged

feat: DIA-977: Get streaming job status #97

merged 31 commits into from
Apr 24, 2024

Conversation

hakan458
Copy link
Contributor

No description provided.

@robot-ci-heartex
Copy link
Collaborator

Copy link
Contributor

@pakelley pakelley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's a little tough to unit test this flow, but if you can find anything we could cover, it would be nice to at least get something here covered

docker-compose.yml Outdated Show resolved Hide resolved
server/tasks/process_file.py Show resolved Hide resolved
server/tasks/process_file.py Outdated Show resolved Hide resolved
server/tasks/process_file.py Outdated Show resolved Hide resolved
server/tasks/process_file.py Show resolved Hide resolved
server/tasks/process_file.py Show resolved Hide resolved
@robot-ci-heartex
Copy link
Collaborator

@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 72 lines in your changes are missing coverage. Please review.

Project coverage is 45.03%. Comparing base (589f868) to head (012376c).

Files Patch % Lines
server/tasks/process_file.py 0.00% 47 Missing ⚠️
server/app.py 0.00% 25 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
- Coverage   46.28%   45.03%   -1.25%     
==========================================
  Files          39       39              
  Lines        1735     1783      +48     
==========================================
  Hits          803      803              
- Misses        932      980      +48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robot-ci-heartex
Copy link
Collaborator

@robot-ci-heartex
Copy link
Collaborator

@robot-ci-heartex robot-ci-heartex marked this pull request as draft April 23, 2024 08:05
@robot-ci-heartex
Copy link
Collaborator

server/app.py Outdated Show resolved Hide resolved
Copy link
Contributor

@forum-hs forum-hs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added comment about api path

@robot-ci-heartex
Copy link
Collaborator

@robot-ci-heartex robot-ci-heartex marked this pull request as ready for review April 24, 2024 16:56
@robot-ci-heartex
Copy link
Collaborator

server/tasks/process_file.py Show resolved Hide resolved
server/tasks/process_file.py Outdated Show resolved Hide resolved
server/tasks/process_file.py Outdated Show resolved Hide resolved
server/tasks/process_file.py Outdated Show resolved Hide resolved
server/tasks/process_file.py Outdated Show resolved Hide resolved
docker-compose.yml Show resolved Hide resolved
@robot-ci-heartex
Copy link
Collaborator

@robot-ci-heartex
Copy link
Collaborator

@robot-ci-heartex
Copy link
Collaborator

@robot-ci-heartex
Copy link
Collaborator

@robot-ci-heartex
Copy link
Collaborator

@robot-ci-heartex
Copy link
Collaborator

@hakan458 hakan458 merged commit c3ddb83 into master Apr 24, 2024
14 checks passed
@hakan458 hakan458 deleted the fb-dia-977 branch April 24, 2024 21:22
@robot-ci-heartex
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants