Functions for checkout service #6
Conversation
cloud_blobstore/s3.py
Outdated
| """ | ||
| Checks if bucket with specified name exists. | ||
| :param bucket: the bucket to be checked. | ||
| :return: true if specified bucket exists in the AZ. |
cloud_blobstore/s3.py
Outdated
| """ | ||
| exists = True | ||
| try: | ||
| self.s3.meta.client.head_bucket(Bucket=bucket) |
There was a problem hiding this comment.
why not just self.s3_client.head_bucket(Bucket=bucket)?
| @@ -277,3 +278,30 @@ def find_next_missing_parts( | |||
| if parts_resp['IsTruncated'] and search_start == parts_resp['NextPartNumberMarker']: | |||
| # finished examining the results of this batch, move onto the next one | |||
| break | |||
|
|
|||
| def check_bucket_exists(self, bucket: str) -> bool: | |||
There was a problem hiding this comment.
I think this is a bit of a misnomer. This tests if the bucket is accessible, not if it exists.
There was a problem hiding this comment.
if bucket is not accessible I'm also checking the error code.
If it was a 404 error, then the bucket does not exist.
There was a problem hiding this comment.
Ah you are right. I misread the documentation!
Thanks!
cloud_blobstore/s3.py
Outdated
| """ | ||
| Get region associated with a specified bucket name. | ||
| :param bucket: the bucket to be checked. | ||
| :return: region, Note that underying AWS API returns None for default US-East-1, |
| Ensure that the ``check_bucket_exists`` method returns true for FIXTURE AND TEST buckets. | ||
| """ | ||
| handle = self.handle # type: BlobStore | ||
| self.assertEqual(handle.check_bucket_exists(self.test_fixtures_bucket), True) |
There was a problem hiding this comment.
There needs to be a negative test as well.
tests/test_s3blobstore.py
Outdated
| Ensure that the ``get_bucket_region`` method returns true for FIXTURE and TEST buckets. | ||
| """ | ||
| handle = self.handle # type: BlobStore | ||
| self.assertEqual(handle.get_bucket_region(self.test_fixtures_bucket), 'us-east-1') |
There was a problem hiding this comment.
There needs to be a non-us-east-1 test as well.
There was a problem hiding this comment.
great idea, do you have any recommendations as far as buckets available in the context of the test?
cloud_blobstore/__init__.py
Outdated
| """ | ||
| Checks if bucket with specified name exists. | ||
| :param bucket: the bucket to be checked. | ||
| :return: true if specified bucket exists in the AZ. |
cloud_blobstore/__init__.py
Outdated
| """ | ||
| Get region associated with a specified bucket name. | ||
| :param bucket: the bucket to be checked. | ||
| :return: region, Note that underying AWS API returns None for default US-East-1, |
…ckerberg/cloud-blobstore into rkisin-checkout-functions
New functions to support checkout service requirements:
Testing
Added 2 new unit tests for TEST and Fixture buckets
TODO:
Implement Google version of these functions Issue