Skip to content
This repository was archived by the owner on Nov 13, 2023. It is now read-only.

Add set -e to build.sh #30

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add set -e to build.sh #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
#!/bin/bash

# Guarantee script exits with a non-zero return-code if a command below fails.
set -e
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would even recommend to go further

Suggested change
set -e
set -eu -o pipefail

since pipes are used

but in either case - requires review of the script to ensure that nothing ATM relies on tools exiting non-0 etc


# The script requires the openMIINDS repository to be cloned in the same root directory into the directory "openMINDS_documentation".
# This needs to be done externally since we need to push back to it and this can only be achieved when the repo is cloned via the workflow action
if [ ! -d "openMINDS_documentation" ]; then
Expand Down