[Feature] Subtitles support and audio snippets in Test from media #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HugoFara
added
enhancement
ProgramComputer
force-pushed
the
subtitles
branch
3 times, most recently
from
9a2ca1e to
0a9eaf5
Compare
ProgramComputer
force-pushed
the
subtitles
branch
from
0a9eaf5 to
5d0ea80
Compare
ProgramComputer
force-pushed
the
subtitles
branch
from
04cc0fc to
1d28c74
Compare
|
Actually it's a feature I thought about, and your solution seems to be great. Yet I think it will be difficult to integrate it into LWT elegantly, as you would be able to create a text from an audio file, and it implies many different changes (on top of the ones you already brought). As I also want to rebuild the media feature (into something HTML5) compatible, it will be great to integrate your PR at that time, see that for the future! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The capability to parse subtitle files was added. Add a vtt, srt ... as a text, and link the corresponding audio-containing media. The audio will snip to fit the sentences in test mode, so you can play the tracks while testing - a play button will appear if possible.
As implied, it is not supported in long text mode.
A minor change was the Read Words Aloud checkbox in the test didn't keep the check selection when requests were made, so voice synthesis should now work in test mode as well.
I tested it with a video file, so any media file with audio supported on the browser will work.
SeStartSec and SeEndSec were added to Sentences table. These are in milliseconds. How the milliseconds are played depend on the browser. These may need to be adjusted by browser