-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Highlight to speech #147
Conversation
Text-to-speechI'm having giving a try to your work, I think this feature can be quite cool for some users, which is nice. However, it can become a bit violent when it keeps uttering words so I'm thinking of a third way. Basically, we would keep your work, but adding another option: "click to speech". When a user clicks a word dispatches speech. The options would look like that: What do you think of this? Changes to
|
I've changed back to localhost. Your UI modification as a dropdown is a nice addition. LWT does modify server variables, check for "set globals" such as "max_heap_table_size" and "tmp_table_size". These are not being modified at runtime and only after session restart do these changes appear. Not a concern if SQL interactions are handled safely. This line |
For the SYSTEM_ADMIN_VARIABLES, I think it will be better to rewrite the portions of code concerned in a clean way, we can discuss it there: #167 . For the TTS (Text-To-Speech) interactions, would you like to implement the new system of options? So that I can work on fixes on meantime and pull your request when it's ready. |
9cbec1d
to
3c960af
Compare
The new way of options is added now. install.sh changes were removed too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your changes, it's all good for me!
Added an option in settings to pronounce word on mouseover.