Merge pull request #14 from HuehueJS/issue-#13

Issue #13
HuehueJS · Nov 21, 2018 · 3b3793d · 3b3793d
2 parents 30dde78 + 2b269f7
commit 3b3793d
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@huehuejs/common-lang",
   "private": false,
-  "version": "0.1.0",
+  "version": "0.1.2",
   "description": "Exploring",
   "main": "index.js",
   "types": "index.d.ts",

diff --git a/src/index.ts b/src/index.ts
@@ -28,7 +28,7 @@ export const getattr = (obj: any, key: Key | KeyPiece, defaultValue: any = undef
     let currentValue = obj;
     for (let k of (key as Key)) {
         currentValue = currentValue[k];
-        if (currentValue === undefined) {
+        if (isNullOrUndefined(currentValue)) {
             return defaultValue;
         }
     }

diff --git a/test/getattr.spec.ts b/test/getattr.spec.ts
@@ -34,6 +34,10 @@ describe('#getattr', () => {
         let obj = { 'key': 1 }
         expect(getattr(obj, 'wrong_key', 'default')).to.equal('default')
     })
+    it('when key is an array and doesn\'t exists should return the default value',  () => {
+        let obj = { 'key': 1 }
+        expect(getattr(obj, ['wrong_key','another_key'], 'default')).to.equal('default')
+    })
     it('when obj is null should return the default value', () => {
         let obj = null;
         expect(getattr(obj, 'key', 'default')).to.equal('default')