Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenEXR export #44

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

rawnsley
Copy link
Contributor

@rawnsley rawnsley commented Oct 4, 2021

Added support for OpenEXR by defining a new extension MOZ_texture_exr

Here's an example Blender scene with EXR images for testing: https://github.com/LearnHub/HubHenge/tree/exr-version

@rawnsley
Copy link
Contributor Author

@keianhzo coincidentally this PR addresses this comment you added last year

@keianhzo keianhzo self-requested a review July 12, 2023 12:22
keianhzo
keianhzo approved these changes Jul 12, 2023
@keianhzo keianhzo self-requested a review July 12, 2023 12:22
@Exairnous
Copy link
Contributor

Exairnous commented Jul 13, 2023

The code seems good. This isn't a user facing change, so I don't see any problem with adding it, but I thought that supporting EXR wasn't a direction the Hubs team wanted to go in right now, so has that changed, or is this something you need for your client? I think EXR support is nice to have, so thanks 🙂 I'm a bit curious though.

@rawnsley
Copy link
Contributor Author

I discussed our use case in this companion PR, but basically EXR format is a better intermediate format to go into our post-processing tools as it preserves precision and has a wide range of layout options including alpha channels and file compression. We added support in Hubs itself because it is sometimes useful to review the scene without post-processing and compare before and after.

@Exairnous
Copy link
Contributor

Ah, okay. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants