-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenEXR export #44
base: master
Are you sure you want to change the base?
OpenEXR export #44
Conversation
# Conflicts: # gather_properties.py
@keianhzo coincidentally this PR addresses this comment you added last year |
The code seems good. This isn't a user facing change, so I don't see any problem with adding it, but I thought that supporting EXR wasn't a direction the Hubs team wanted to go in right now, so has that changed, or is this something you need for your client? I think EXR support is nice to have, so thanks 🙂 I'm a bit curious though. |
I discussed our use case in this companion PR, but basically EXR format is a better intermediate format to go into our post-processing tools as it preserves precision and has a wide range of layout options including alpha channels and file compression. We added support in Hubs itself because it is sometimes useful to review the scene without post-processing and compare before and after. |
Ah, okay. Thank you. |
Added support for OpenEXR by defining a new extension
MOZ_texture_exr
Here's an example Blender scene with EXR images for testing: https://github.com/LearnHub/HubHenge/tree/exr-version