-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support arguments (canonicalQueryString) and UNSIGNED-PAYLOAD #2
base: master
Are you sure you want to change the base?
Conversation
0b08243 fixes the empty QueryStrings :) Last thing to do is be more smart about routing requests like ?delete (bulk removals), but this is gonna require a fair bit more work, possibly outside of this library |
Hey @smiba , I'm not wure when I'll have a chance to test this in our own infra before merging. I take it you are able to use your own fork for now and aren't blocked here? Thanks for the contribution by the way! |
Yes! We're using this and it's been working fine, I specifically made these contributions to the code for our infra (Even made a little write-up which includes using this library: https://medium.com/@PurpleDug/woof-tech-routing-s3-endpoints-and-doing-a-live-migration-on-a-production-environment-as-a-treat-8fa2bbd6784e) |
Slightly messy PR, sorry about that
These changes provide
ngx.var.request_body
is empty (might happen when it does not fit in nginx body buffer)To do: