Update status code error types #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,19 +9,7 @@ function isSystemError(err: BaseError) { | |||
| } | |||
|
|
|||
| function debugErrorAndContext(error: BaseError, context?: ErrorContext): void { | |||
| if (error.name === 'StatusCodeError') { | |||
There was a problem hiding this comment.
Does removing this result in more content being logged to the console? Is this filtering out some of the extra content that gets included on the error object for status code errors?
There was a problem hiding this comment.
errors_DEPRECATED is only used with the old config_DEPRECATED to make sure the logging was identical. Config doesn't make any requests so there won't be any StatusCodeErrors thrown
There was a problem hiding this comment.
Ah thanks for explaining. I didn't notice the file that this was in 👍
brandenrodgers
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
A few months ago, we switched from using
requestandrequest-promise-nativetoaxios, but never updated the types for http related errors. This PR removed theStatusCodeErrortype associated withrequestand updates instances of it to instead useAxiosErrorTODO
Should make sure to test this thoroughly. To my knowledge, the nothing currently being used by the CLI threw
StatusCodeErrors so this should be relatively safe. I've tested with my upcoming PR that did rely onStatusCodeErrorHubSpot/hubspot-cli#964Who to Notify
@brandenrodgers