Spike to clean up the lang file #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camden11
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
I removed the top level
debug.anderrors.keys in the lang file. Now each file will directly reference the path to the translation, regardless of whether it's a debug statement or an error that's being thrown. This should remove some of the "magic", which should make it a little easier to avoid making translations mistakes.I may put up a follow up PR to make more tweaks to this, but this seemed like a good place to stop. I ran through every translation in the lang file and I'm pretty sure all of the keys are correct, but we should definitely make sure to test this out a bit before merging.
Screenshots
TODO
Who to Notify