Unit tests for personalAccessKey utils #53
Conversation
types/Accounts.ts
Outdated
| // personalaccesskey = 'personalaccesskey', | ||
| // apikey = 'apikey', | ||
| // oauth2 = 'oauth2', | ||
| // } |
There was a problem hiding this comment.
Did you mean to leave this in?
There was a problem hiding this comment.
Nope, good catch
package.json
Outdated
| @@ -25,7 +25,7 @@ | |||
| "release:major": "yarn check-main && yarn version --major && yarn build && yarn pub && yarn push", | |||
| "release:minor": "yarn check-main && yarn version --minor && yarn build && yarn pub && yarn push", | |||
| "release:patch": "yarn check-main && yarn version --patch && yarn build && yarn pub && yarn push", | |||
| "test": "jest --silent" | |||
| "test": "jest" | |||
There was a problem hiding this comment.
Just curious why you're removing this here. With it off, every console.log and console.debug gets triggered which I found a little distracting. Was there anything important that was getting skipped over?
There was a problem hiding this comment.
Also noticed you changed this in your other PR so might end up with a conflict
There was a problem hiding this comment.
I took this out because it made debugging the tests really difficult. I was trying to console log and wasn't seeing any of the output. I figured that we can manually run with yarn run test --silent if the output gets annoying. After playing around with it for a while though, the console logs didn't bother me.
Description and Context
Copying unit tests from cli-lib for personalAccessKey.
Screenshots
TODO
Who to Notify