Merge pull request #71 from HubSpot/streamline-error-messaging

Streamline error messaging
HubSpot · Dec 13, 2023 · 7149116 · 7149116
2 parents 963799c + 33556fc
commit 7149116
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/errors/standardErrors.ts b/errors/standardErrors.ts
@@ -73,8 +73,10 @@ export function throwError(error: BaseError): never {
     throwStatusCodeError(error as StatusCodeError);
   } else {
     // Error or Error subclass
-    const name = error.name || 'Error';
-    const message = [i18n('errors.generic', { name })];
+    const message =
+      error.name && error.name !== 'Error'
+        ? [i18n('errors.generic', { name: error.name })]
+        : [];
     [error.message, error.reason].forEach(msg => {
       if (msg) {
         message.push(msg);

diff --git a/lang/en.json b/lang/en.json
@@ -378,6 +378,6 @@
         "generic": "The {{ messageDetail }} failed."
       }
     },
-    "generic": "A {{ name }} has occurred"
+    "generic": "{{ name }}:"
   }
 }