Convert lib/serverlessLogs and lib/buildAccount to TS #1337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camden11
requested review from
brandenrodgers,
kemmerle and
joe-yeager
as code owners
camden11
commented
Jan 13, 2025
|
|
||
| beforeEach(() => { | ||
| jest.spyOn(process, 'exit').mockImplementation(() => {}); | ||
| stdinMock = mockStdIn.stdin(); | ||
| spinnies = { |
There was a problem hiding this comment.
This was being passed into tailLogs but not doing anything
camden11
commented
Jan 13, 2025
| portalLimit, // Used only for developer test accounts | ||
| force = false, | ||
| }) { | ||
| export async function buildDeveloperTestAccount( |
There was a problem hiding this comment.
I decided to split buildNewAccount into two separate functions. It adds a few extra lines of code, but IMO is much easier to read. I don't think there was a ton of utility in combining them previously, since it only combined two account types and would have been super messy if we ever attempted to add a third. It also was more or less impossible to safely type
brandenrodgers
approved these changes
Jan 15, 2025
| }) | ||
| ); | ||
| logger.debug(e); |
There was a problem hiding this comment.
Not a blocker, but could this use the debugError() util?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
Converts 2 more files to TS. Only two more to go after this!
https://git.hubteam.com/HubSpot/hubspot-cli-issues/issues/684
Who to Notify
@brandenrodgers @kecarroll @joe-yeager