port validation and configOptions to TS #1309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandenrodgers
commented
Dec 17, 2024
| { | ||
| type: 'list', | ||
| look: false, |
There was a problem hiding this comment.
look does not exist as a supported field (search in repo)
brandenrodgers
commented
Dec 17, 2024
| @@ -91,25 +102,24 @@ const setDefaultCmsPublishMode = async ({ | |||
| newDefault = defaultCmsPublishMode; | |||
| } else { | |||
| logger.error( | |||
| i18n(`${i18nKey}.defaultMode.errors`, { | |||
| mode: newDefault, | |||
| i18n(`${i18nKey}.defaultMode.error`, { | |||
There was a problem hiding this comment.
We were using the wrong lang key, and newDefault is undefined here
brandenrodgers
commented
Dec 17, 2024
| @@ -134,13 +150,7 @@ const setHttpTimeout = async ({ accountId, httpTimeout }) => { | |||
|
|
|||
| updateHttpTimeout(newHttpTimeout); | |||
|
|
|||
| return logger.success( | |||
| logger.success( | |||
There was a problem hiding this comment.
There's no need for any of these to return
brandenrodgers
commented
Dec 17, 2024
brandenrodgers
commented
Dec 17, 2024
| validModes: commaSeparatedValues(ALL_CMS_PUBLISH_MODES), | ||
| }) | ||
| ); | ||
| newDefault = await selectCMsPublishMode(); | ||
| newDefault = await selectCmsPublishMode(); |
There was a problem hiding this comment.
We had a casing issue here that TS picked up 🎉
brandenrodgers
requested review from
camden11,
kemmerle and
joe-yeager
as code owners
camden11
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
This is dependent on HubSpot/hubspot-local-dev-lib#223
This ports lib/validation.ts and lib/configOptions.ts to Typescript. I found some bugs while doing this that I'll call out inline.
Screenshots
TODO
Who to Notify