Convert Oauth, Polling, and Projects to TS #1306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camden11
requested review from
brandenrodgers,
kemmerle and
joe-yeager
as code owners
types/projects.ts
Outdated
| @@ -0,0 +1,51 @@ | |||
| import { Build, SubbuildStatus } from '@hubspot/local-dev-lib/types/Build'; | |||
There was a problem hiding this comment.
Nit, but in LDL we capitalize the filenames for everything in the types/ folder
|
Up to you, but if you wanted you could probably cut |
lib/projects/index.ts
Outdated
| console.log(error); | ||
| uploadResult = { uploadError: error }; | ||
| } else if (callbackFunc) { | ||
| console.log('callbackfunc'); |
There was a problem hiding this comment.
Looks like a console log snuck in
|
I changed the casing of |
brandenrodgers
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
This converts the following
libfiles to TSoauthpollingprojectsIt also restructures the projects lib files, since
lib/projectswas over 1200 lines long. All projects related lib files have been moved into the/projectsdir.lib/projects.tshas been split into two files - all functionality related to builds and deploys has been moved tolib/projects/buildAndDeploy.ts. The remaining functionality is not inlib/projects/index.tsNeed to merge and release this LDL PR before type checks will pass
HubSpot/hubspot-local-dev-lib#221
Who to Notify
@brandenrodgers @joe-yeager @kemmerle