feat: Add translation to IR #1252
Open
+64
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe-yeager
requested review from
brandenrodgers,
camden11 and
kemmerle
as code owners
joe-yeager
commented
Dec 19, 2024
Comment on lines
+134
to
+138
| translate: { | ||
| hidden: true, | ||
| type: 'boolean', | ||
| default: false, | ||
| }, |
There was a problem hiding this comment.
I added this to hs project upload but not hs project watch primarily because hs project watch gets almost no usage, and there were some other road bumps, such as hs project watch doesn't work unless your project already has a successful build, which is not currently achievable with the new system.
I can add the options to hs project watch if we think it is worthwhile, but the command won't work until build scheduling is in place and component teams have begun to implement their builds.
| @@ -43,6 +43,8 @@ exports.handler = async options => { | |||
|
|
|||
| const { projectConfig, projectDir } = await getProjectConfig(); | |||
|
|
|||
| trackCommandUsage('project-upload', { type: accountType }, derivedAccountId); | |||
There was a problem hiding this comment.
is this a duplicate tracking call?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
Integrate with
@hubspot/projects-parsing-liband the new projects upload API