Skip to content

Commit

Permalink
Merge pull request #278 from HubSpot/update/discoveries
Browse files Browse the repository at this point in the history
Discoveries: Update for CrmObjects
  • Loading branch information
alzheltkovskiy-hubspot authored Mar 4, 2024
2 parents a0e5a88 + 38f655b commit 023bb9c
Show file tree
Hide file tree
Showing 6 changed files with 27 additions and 11 deletions.
12 changes: 8 additions & 4 deletions hubspot/discovery/crm/companies/discovery.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,17 +8,21 @@ class Discovery(DiscoveryBase):
def basic_api(self) -> api_client.BasicApi:
return self._configure_api_client(api_client, "BasicApi")

@property
def search_api(self) -> api_client.SearchApi:
return self._configure_api_client(api_client, "SearchApi")

@property
def batch_api(self) -> api_client.BatchApi:
return self._configure_api_client(api_client, "BatchApi")

@property
def gpdr_api(self) -> api_client.GDPRApi:
return self._configure_api_client(api_client, "GDPRApi")

@property
def public_object_api(self) -> api_client.PublicObjectApi:
return self._configure_api_client(api_client, "PublicObjectApi")

@property
def search_api(self) -> api_client.SearchApi:
return self._configure_api_client(api_client, "SearchApi")

def get_all(self, **kwargs):
return fetch_all(self.basic_api, **kwargs)
12 changes: 8 additions & 4 deletions hubspot/discovery/crm/deals/discovery.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,17 +8,21 @@ class Discovery(DiscoveryBase):
def basic_api(self) -> api_client.BasicApi:
return self._configure_api_client(api_client, "BasicApi")

@property
def search_api(self) -> api_client.SearchApi:
return self._configure_api_client(api_client, "SearchApi")

@property
def batch_api(self) -> api_client.BatchApi:
return self._configure_api_client(api_client, "BatchApi")

@property
def gdpr_api(self) -> api_client.GDPRApi:
return self._configure_api_client(api_client, "GDPRApi")

@property
def public_object_api(self) -> api_client.PublicObjectApi:
return self._configure_api_client(api_client, "PublicObjectApi")

@property
def search_api(self) -> api_client.SearchApi:
return self._configure_api_client(api_client, "SearchApi")

def get_all(self, **kwargs):
return fetch_all(self.basic_api, **kwargs)
4 changes: 4 additions & 0 deletions hubspot/discovery/crm/extensions/calling/discovery.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,7 @@ class Discovery(DiscoveryBase):
@property
def settings_api(self) -> api_client.SettingsApi:
return self._configure_api_client(api_client, "SettingsApi")

@property
def recording_settings_api(self) -> api_client.RecordingSettingsApi:
return self._configure_api_client(api_client, "RecordingSettingsApi")
4 changes: 3 additions & 1 deletion tests/spec/crm/extensions/test_calling.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
from hubspot import HubSpot
from hubspot.crm.extensions.calling import SettingsApi
from hubspot.crm.extensions.calling import SettingsApi, RecordingSettingsApi


def test_is_discoverable():
apis = HubSpot().crm.extensions.calling
assert isinstance(apis.settings_api, SettingsApi)
assert isinstance(apis.recording_settings_api, RecordingSettingsApi)
3 changes: 2 additions & 1 deletion tests/spec/crm/test_companies.py
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
from hubspot import HubSpot
from hubspot.crm.companies import BasicApi, BatchApi, SearchApi, PublicObjectApi
from hubspot.crm.companies import BasicApi, BatchApi, GDPRApi, SearchApi, PublicObjectApi


def test_is_discoverable():
apis = HubSpot().crm.companies
assert isinstance(apis.basic_api, BasicApi)
assert isinstance(apis.batch_api, BatchApi)
assert isinstance(apis.gpdr_api, GDPRApi)
assert isinstance(apis.search_api, SearchApi)
assert isinstance(apis.public_object_api, PublicObjectApi)
assert hasattr(apis, "get_all")
3 changes: 2 additions & 1 deletion tests/spec/crm/test_deals.py
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
from hubspot import HubSpot
from hubspot.crm.deals import BasicApi, BatchApi, SearchApi, PublicObjectApi
from hubspot.crm.deals import BasicApi, BatchApi, GDPRApi, SearchApi, PublicObjectApi


def test_is_discoverable():
apis = HubSpot().crm.deals
assert isinstance(apis.basic_api, BasicApi)
assert isinstance(apis.batch_api, BatchApi)
assert isinstance(apis.gdpr_api, GDPRApi)
assert isinstance(apis.search_api, SearchApi)
assert isinstance(apis.public_object_api, PublicObjectApi)
assert hasattr(apis, "get_all")

0 comments on commit 023bb9c

Please sign in to comment.