Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds auto-wiring of jetty LifeCycle.Listener instances #63

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,10 @@
<groupId>org.eclipse.jetty</groupId>
<artifactId>jetty-server</artifactId>
</dependency>
<dependency>
<groupId>org.eclipse.jetty</groupId>
<artifactId>jetty-util</artifactId>
</dependency>

<dependency>
<groupId>junit</groupId>
Expand Down
10 changes: 10 additions & 0 deletions src/main/java/com/hubspot/dropwizard/guicier/DropwizardModule.java
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
import io.dropwizard.lifecycle.ServerLifecycleListener;
import io.dropwizard.servlets.tasks.Task;
import io.dropwizard.setup.Environment;
import org.eclipse.jetty.util.component.LifeCycle;
import org.glassfish.jersey.server.ResourceConfig;
import org.glassfish.jersey.server.model.Resource;
import org.slf4j.Logger;
Expand Down Expand Up @@ -51,6 +52,10 @@ public <T> void onProvision(ProvisionInvocation<T> provision) {
if (obj instanceof ServerLifecycleListener) {
handle((ServerLifecycleListener) obj);
}

if (obj instanceof LifeCycle.Listener) {
handle((LifeCycle.Listener) obj);
}
}
});
}
Expand Down Expand Up @@ -79,6 +84,11 @@ private void handle(ServerLifecycleListener serverLifecycleListener) {
LOG.info("Added guice injected server lifecycle listener: {}", serverLifecycleListener.getClass().getName());
}

private void handle(LifeCycle.Listener lifecycleListener) {
environment.lifecycle().addLifeCycleListener(lifecycleListener);
LOG.info("Added guice injected lifecycle listener: {}", lifecycleListener.getClass().getName());
}

private void registerResourcesAndProviders(ResourceConfig config, Injector injector) {
while (injector != null) {
for (Key<?> key : injector.getBindings().keySet()) {
Expand Down
24 changes: 24 additions & 0 deletions src/test/java/com/hubspot/dropwizard/guicier/GuiceBundleTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

import com.hubspot.dropwizard.guicier.objects.InstanceManaged;
import com.hubspot.dropwizard.guicier.objects.ProvidedHealthCheck;
import com.hubspot.dropwizard.guicier.objects.ProvidedLifecycleListener;
import com.hubspot.dropwizard.guicier.objects.ProvidedManaged;
import com.hubspot.dropwizard.guicier.objects.ProvidedProvider;
import com.hubspot.dropwizard.guicier.objects.ProvidedServerLifecycleListener;
Expand All @@ -27,6 +28,7 @@
import com.google.inject.Injector;
import com.hubspot.dropwizard.guicier.objects.ExplicitResource;
import com.hubspot.dropwizard.guicier.objects.InjectedHealthCheck;
import com.hubspot.dropwizard.guicier.objects.InjectedLifecycleListener;
import com.hubspot.dropwizard.guicier.objects.InjectedManaged;
import com.hubspot.dropwizard.guicier.objects.InjectedProvider;
import com.hubspot.dropwizard.guicier.objects.InjectedServerLifecycleListener;
Expand Down Expand Up @@ -121,10 +123,21 @@ public void itAddsBoundServerLifecycleListener() {
assertThat(environment.lifecycle())
.extracting(Function.identity())
.flatExtracting("lifecycleListeners")
.filteredOn(obj -> obj.getClass().getName().contains("ServerListener"))
.extracting("listener")
.containsOnlyOnce(injectedServerLifecycleListener);
}

@Test
public void itAddsBoundLifecycleLIstener() {
InjectedLifecycleListener injectedLifecycleListener =
guiceBundle.getInjector().getInstance(InjectedLifecycleListener.class);
assertThat(environment.lifecycle())
.extracting(Function.identity())
.flatExtracting("lifecycleListeners")
.containsOnlyOnce(injectedLifecycleListener);
}

@Test
public void itAddsBoundProvider() {
Set<Class<?>> components = environment.jersey().getResourceConfig().getClasses();
Expand Down Expand Up @@ -167,10 +180,21 @@ public void itAddsProvidedServerLifecycleListener() {
assertThat(environment.lifecycle())
.extracting(Function.identity())
.flatExtracting("lifecycleListeners")
.filteredOn(obj -> obj.getClass().getName().contains("ServerListener"))
.extracting("listener")
.containsOnlyOnce(providedServerLifecycleListener);
}

@Test
public void itAddsProvidedLifecycleListener() {
ProvidedLifecycleListener providedLifecycleListener =
guiceBundle.getInjector().getInstance(ProvidedLifecycleListener.class);
assertThat(environment.lifecycle())
.extracting(Function.identity())
.flatExtracting("lifecycleListeners")
.containsOnlyOnce(providedLifecycleListener);
}

@Test
public void itAddsProvidedProvider() {
Set<Class<?>> components = environment.jersey().getResourceConfig().getClasses();
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
package com.hubspot.dropwizard.guicier.objects;

import com.google.inject.Inject;
import com.google.inject.Singleton;
import org.eclipse.jetty.util.component.LifeCycle;

@Singleton
public class InjectedLifecycleListener implements LifeCycle.Listener {

@Inject
InjectedLifecycleListener() {}

@Override
public void lifeCycleStarting(LifeCycle lifeCycle) {
}

@Override
public void lifeCycleStarted(LifeCycle lifeCycle) {
}

@Override
public void lifeCycleFailure(LifeCycle lifeCycle, Throwable throwable) {
}

@Override
public void lifeCycleStopping(LifeCycle lifeCycle) {
}

@Override
public void lifeCycleStopped(LifeCycle lifeCycle) {
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
package com.hubspot.dropwizard.guicier.objects;

import org.eclipse.jetty.util.component.LifeCycle;

public class ProvidedLifecycleListener implements LifeCycle.Listener {

@Override
public void lifeCycleStarting(LifeCycle lifeCycle) {
}

@Override
public void lifeCycleStarted(LifeCycle lifeCycle) {
}

@Override
public void lifeCycleFailure(LifeCycle lifeCycle, Throwable throwable) {
}

@Override
public void lifeCycleStopping(LifeCycle lifeCycle) {
}

@Override
public void lifeCycleStopped(LifeCycle lifeCycle) {
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ protected void configure() {
bind(InjectedTask.class).asEagerSingleton();
bind(InjectedHealthCheck.class).asEagerSingleton();
bind(InjectedServerLifecycleListener.class).asEagerSingleton();
bind(InjectedLifecycleListener.class).asEagerSingleton();

bind(InjectedProvider.class);

Expand Down Expand Up @@ -53,6 +54,12 @@ public ProvidedServerLifecycleListener provideServerLifecycleListener() {
return new ProvidedServerLifecycleListener();
}

@Provides
@Singleton
public ProvidedLifecycleListener provideLifecycleListener() {
return new ProvidedLifecycleListener();
}

@Provides
public ProvidedProvider provideProvider() {
return new ProvidedProvider();
Expand Down