Add deprecation annotations to ported utils #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camden11
reviewed
Jan 3, 2024
There was a problem hiding this comment.
There's a few places where it might be helpful to indicate the new import path. I also noticed there's a few more places where we'll need to add the annotation:
git.jssandboxes.jstrackUsagewithinfilemapper.js(new import path:@hubspot/local-dev-lib/trackUsage)
|
@camden11 I added deprecation annotations to the sandboxes and trackUsage exports, but it looks like the CLI is still using the git utils exported from cli-lib. |
camden11
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
@brandenrodgers it's not using the github utils, but confusingly there's a separate file called git.js that it is using. (this has been renamed to gitignore.ts in local dev lib) Approving but just make sure to add that final annotaiton before you merge!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
Adding deprecation annotations to exported utils that the HubSpot CLI is now importing from the new local-dev-lib library. This should help to prevent new changes from being made in this library for exports that aren't being used anymore.
Screenshots
TODO
Who to Notify