Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C# Metaprogramming #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

OlegStelmah
Copy link

Oleg Stelmah IT-42

Oleg Stelmah IT-42
@OlegStelmah OlegStelmah changed the title C# Metaprogra C# Metaprogramming Jun 6, 2017
@GYFK GYFK requested a review from Raixur June 6, 2017 21:39
Copy link

@Raixur Raixur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good.

};
static void Main(string[] args)
{
new FilterSimple().filter(names).ForEach(delegate (String name)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may use lambdas instead of delegate (just a recommendation).


private static Boolean check(String s, Dictionary<String, Object> conditions)
{
Boolean valid;
Copy link

@Raixur Raixur Jun 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to use type keyword bool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants