Integrating with the latest Facepunch Steamworks API and populating steam lobby class. #5
Conversation
…nd other changes to connect member metadata
| @@ -27,10 +27,14 @@ internal class SteamLobby : Lobby { | |||
|
|
|||
| readonly SteamLobbyManager _manager; | |||
|
|
|||
| public SteamLobby(Steamworks.Data.Lobby lobby, SteamLobbyManager manager) : base() { | |||
| public SteamLobby(Steamworks.Data.Lobby lobby, SteamLobbyManager manager, bool connected) : base() { | |||
There was a problem hiding this comment.
Please make this default to false.
| } | ||
| //if (!_lobby.SendChatBytes(ptr, msg.Length)) { | ||
| // Debug.LogError("Failed to send Steam Lobby Packet."); | ||
| //} |
There was a problem hiding this comment.
Any reason this was commented out?
There was a problem hiding this comment.
Sending chat bytes are no longer supported through facepunch. I'm just going to throw a NotImplemented error then.
| @@ -63,7 +67,7 @@ internal class SteamLobby : Lobby { | |||
| if (handle.Id != UserId) { | |||
| throw new InvalidOperationException("Cannnot set the metadata of a Steam lobby member other than the current user."); | |||
| } | |||
| _lobby.SetMemberData(new Friend(handle.Id), key, value); | |||
| _lobby.SetMemberData( key, value); | |||
There was a problem hiding this comment.
Remove the extra space before key.
| @@ -27,6 +27,8 @@ internal class SteamLobbyManager : ILobbyManager { | |||
| SteamMatchmaking.OnLobbyMemberDisconnected += OnLobbyMemberLeave; | |||
| SteamMatchmaking.OnLobbyMemberKicked += OnLobbyMemberRemoved; | |||
| SteamMatchmaking.OnLobbyMemberBanned += OnLobbyMemberRemoved; | |||
|
|
|||
| @@ -73,7 +75,7 @@ internal class SteamLobbyManager : ILobbyManager { | |||
| if (result == null) return new Lobby[0]; | |||
| var lobbies = new Lobby[result.Length]; | |||
| for (var i = 0; i < lobbies.Length; i++) { | |||
| lobbies[i] = new SteamLobby(result[i], this); | |||
| lobbies[i] = new SteamLobby(result[i], this, false); | |||
There was a problem hiding this comment.
Once the default has been set to false, remove this change.
| var comp = (LobbyComparison)((int)comparison); | ||
| _query.AddStringFilter(key, value, comp); | ||
| //var comp = (LobbyComparison)((int)comparison); | ||
| //_query.AddStringFilter(key, value, comp); |
There was a problem hiding this comment.
This actively breaks the search builder. Is this now deprecated?
There was a problem hiding this comment.
Yup it's deprecated now. I'm going to fix it to work with the new API then.
| var comp = (LobbyComparison)((int)comparison); | ||
| _query.AddNumericalFilter(key, value, comp); | ||
| //var comp = (LobbyComparison)((int)comparison); | ||
| //_query.AddNumericalFilter(key, value, comp); |
There was a problem hiding this comment.
Same here with this commented out section.
There was a problem hiding this comment.
Same comment as above. See the new merge (I'll push it in a bit)
| @@ -217,6 +220,8 @@ class LobbySearchBuilder : ILobbySearchBuilder { | |||
| Debug.LogWarning($"[Steam] Unexpected lobby member update event for lobby: {steamLobby.Id}"); | |||
| return; | |||
| } | |||
|
|
|||
| Debug.Log("member changed!!!"); | |||
There was a problem hiding this comment.
If this is just to debug. Please remove this.
| @@ -16,7 +16,7 @@ public class LobbyMember : INetworkConnection, IMetadataContainer, IDisposable { | |||
| public static IMessageProcessor MessageProcessor; | |||
|
|
|||
| static LobbyMember() { | |||
| MessageProcessor = new LZFCompressor(); | |||
| MessageProcessor = null; | |||
There was a problem hiding this comment.
Any particular reason this was removed?
There was a problem hiding this comment.
Using LZFCompressor instantly crashes Unity. I'm not sure where it goes wrong so I just commented it out.
There was a problem hiding this comment.
OK, that's a sign we have a memory access violation somewhere in our code. I think we can keep this for now, but please leave a TODO(james7132) comment to investigate this. The LZF compression is part of the reason why we have been able to keep our bandwidth usage low despite sending a network message basically every tick in Backroll.
|
OK this looks good enough, sans the SendChatBytes change. This is just pending an updated Facepunch UPM package to merge this in. |
Updating steam lobbies to work with latest Facepunch Steamworks api.
Makes sure that lobby data is set for steamlobbies and that member data is updated.