Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

md5deep: support for ARM #70616

Closed
wants to merge 2 commits into from
Closed

Conversation

paulhammond
Copy link
Contributor

md5deep currently fails to install on Apple Silicon thanks to an outdated copy of the GNU config scripts in that repo. The issue has been reported upstream. Until they fix it this pull request adds a minimal patch to get the homebrew formula compiling again.


  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

brew audit --strict warns that GPL-2.0 is not a valid license which is not related to these changes. Not sure if you'd like that fixed in this PR too?

@BrewTestBot BrewTestBot added deprecated license Formula uses a deprecated SPDX license which should be updated no ARM bottle Formula has no ARM bottle labels Feb 7, 2021
@dtrodrigues dtrodrigues added the CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. label Feb 7, 2021
@carlocab
Copy link
Member

carlocab commented Feb 7, 2021

Not sure if you'd like that fixed in this PR too?

If you could fix it now too, that'd be much appreciated.

@dtrodrigues
Copy link
Member

The license is a bit complex, I think it's fine to be taken of later on:
https://github.com/jessek/hashdeep/blob/master/COPYING#L1-L16

This program is divided into two parts, the Tiger code and everything 
else. Let's start with everything else:

This program is a work of the US Government. In accordance with 17 USC 
105, copyright protection is not available for any work of the US 
Government. As such this code is considered public domain. There is NO 
warranty for this program; not even for MERCHANTABILITY or FITNESS FOR A 
PARTICULAR PURPOSE.

The code for Tiger comes from the libgcrypt project and is licensed 
under the General Public License (GPL).

Because the vast majority of this program is public domain, the license 
of this project as whole remains public domain. The Tiger code itself is 
still licensed under the GPL. Note that this dual licensing scheme does 
not violate the terms of the GPL. Please see the GPL FAQ, specifically:

dtrodrigues
dtrodrigues previously approved these changes Feb 7, 2021
Copy link
Member

@dtrodrigues dtrodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @paulhammond

@BrewTestBot
Copy link
Member

:shipit: @dtrodrigues has triggered a merge.

@BrewTestBot
Copy link
Member

⚠️ @dtrodrigues bottle publish failed.

@BrewTestBot BrewTestBot dismissed dtrodrigues’s stale review February 7, 2021 19:39

bottle publish failed

@BrewTestBot
Copy link
Member

:shipit: @dtrodrigues has triggered a merge.

@paulhammond paulhammond deleted the md5deep-arm branch February 7, 2021 21:16
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Mar 10, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Mar 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. deprecated license Formula uses a deprecated SPDX license which should be updated no ARM bottle Formula has no ARM bottle outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants