Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cataclysm: fix head dependency for macOS build #196941

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

PCtzonoes
Copy link
Contributor

@PCtzonoes PCtzonoes commented Nov 7, 2024

This commit ensures that the freetype dependency is included when building the head version on macOS.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Nov 7, 2024
Copy link
Contributor

github-actions bot commented Nov 7, 2024

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@carlocab carlocab changed the title Fix head dependency for macOS build cataclysm: fix head dependency for macOS build Nov 7, 2024
@carlocab carlocab added CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. CI-no-bottles Merge without publishing bottles labels Nov 7, 2024
Formula/c/cataclysm.rb Outdated Show resolved Hide resolved
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I have a comment below. When you fix it, please amend your existing commit (instead of adding new ones) and use the commit message

cataclysm: fix head dependency for macOS build

(or similar)

See these guidelines from our commit style guide:

The required commit message format for simple version updates is foobar 7.3 and for fixes is foobar: fix flibble matrix..

  • One formula per commit; one commit per formula.
  • Keep merge commits out of the pull request.

@PCtzonoes PCtzonoes force-pushed the cataclysm-fix-head-dependency branch from 2d3a44f to 805e42f Compare November 7, 2024 05:20
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Nov 7, 2024
@PCtzonoes
Copy link
Contributor Author

After reviewing the formula, it’s evident that the installation via make implicitly fetches the latest version (head) by default. As a result, I will remove the explicit requirement for this in the new dependency. The stable one gets directly from the project's Repo Releases

@PCtzonoes PCtzonoes force-pushed the cataclysm-fix-head-dependency branch from 805e42f to fb8cc4d Compare November 7, 2024 05:43
@carlocab carlocab removed CI-no-bottles Merge without publishing bottles CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. labels Nov 7, 2024
@carlocab
Copy link
Member

carlocab commented Nov 7, 2024

After reviewing the formula, it’s evident that the installation via make implicitly fetches the latest version (head) by default.

Wait, it does? We don't want it to do that. However, if it is doing that -- doesn't that mean freetype isn't actually needed?

Formula/c/cataclysm.rb Outdated Show resolved Hide resolved
This commit ensures that the freetype dependency is included in 'head' when building with make on macOS.
@PCtzonoes
Copy link
Contributor Author

Due to the 'head' and 'head do' restrictions of the strict formatting, I had to reformat the formula. I’m not entirely satisfied with the result but followed the required style changes.

@carlocab carlocab added CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. CI-no-bottles Merge without publishing bottles labels Nov 11, 2024
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@carlocab carlocab added this pull request to the merge queue Nov 11, 2024
Merged via the queue into Homebrew:master with commit f3188b4 Nov 11, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-bottles Merge without publishing bottles CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants