-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cataclysm: fix head dependency for macOS build #196941
cataclysm: fix head dependency for macOS build #196941
Conversation
Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I have a comment below. When you fix it, please amend your existing commit (instead of adding new ones) and use the commit message
cataclysm: fix head dependency for macOS build
(or similar)
See these guidelines from our commit style guide:
The required commit message format for simple version updates is
foobar 7.3
and for fixes isfoobar: fix flibble matrix.
.
- One formula per commit; one commit per formula.
- Keep merge commits out of the pull request.
2d3a44f
to
805e42f
Compare
After reviewing the formula, it’s evident that the installation via make implicitly fetches the latest version (head) by default. As a result, I will remove the explicit requirement for this in the new dependency. The stable one gets directly from the project's Repo Releases |
805e42f
to
fb8cc4d
Compare
Wait, it does? We don't want it to do that. However, if it is doing that -- doesn't that mean |
This commit ensures that the freetype dependency is included in 'head' when building with make on macOS.
fb8cc4d
to
2ec2603
Compare
Due to the 'head' and 'head do' restrictions of the strict formatting, I had to reformat the formula. I’m not entirely satisfied with the result but followed the required style changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This commit ensures that the freetype dependency is included when building the head version on macOS.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?