Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python-freethreading: update livecheck and sync with py3.13 formulae #196391

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

chenrui333
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@chenrui333 chenrui333 added livecheck Issues or PRs related to livecheck CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. labels Nov 1, 2024
Copy link
Member

@samford samford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't a versioned formula, so we may get into a situation where the version that's used in the regex isn't kept in sync with the latest stable version of Python in this case. Unless I'm missing something (e.g., technical restrictions, etc.), referencing the python alias would achieve the same goal without requiring anyone to remember to manually update this regex when we package a newer Python version.

Formula/p/python-freethreading.rb Outdated Show resolved Hide resolved
Formula/p/python-freethreading.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Nov 1, 2024
Signed-off-by: Rui Chen <[email protected]>

Co-authored-by: Sam Ford <[email protected]>
@chenrui333 chenrui333 force-pushed the python-freethreading-livecheck branch from 5a1b077 to 0b22071 Compare November 1, 2024 20:19
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Nov 1, 2024
@chenrui333
Copy link
Member Author

good call, using python is a better choice

@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Nov 1, 2024
@chenrui333 chenrui333 changed the title python-freethreading: update livecheck python-freethreading: update livecheck and sync with py3.13 formulae Nov 1, 2024
@chenrui333 chenrui333 removed the automerge-skip `brew pr-automerge` will skip this pull request label Nov 1, 2024
Copy link
Member

@samford samford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming we can't do ["python", "python-freethreading"] in synced_versions_formulae.json, we'll just have to remember to move python-freethreading into the newest Python array when we create formulae for a newer Python version.

@BrewTestBot BrewTestBot added this pull request to the merge queue Nov 1, 2024
@chenrui333
Copy link
Member Author

we'll just have to remember to move python-freethreading into the newest Python array when we create formulae for a newer Python version.

yeah, I can imagine that would be popped up for py3.14

Merged via the queue into master with commit 7f0e390 Nov 1, 2024
19 checks passed
@BrewTestBot BrewTestBot deleted the python-freethreading-livecheck branch November 1, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. livecheck Issues or PRs related to livecheck
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants