-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python-freethreading: update livecheck and sync with py3.13 formulae #196391
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't a versioned formula, so we may get into a situation where the version that's used in the regex isn't kept in sync with the latest stable version of Python in this case. Unless I'm missing something (e.g., technical restrictions, etc.), referencing the python
alias would achieve the same goal without requiring anyone to remember to manually update this regex when we package a newer Python version.
Signed-off-by: Rui Chen <[email protected]> Co-authored-by: Sam Ford <[email protected]>
5a1b077
to
0b22071
Compare
good call, using python is a better choice |
Signed-off-by: Rui Chen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming we can't do ["python", "python-freethreading"]
in synced_versions_formulae.json
, we'll just have to remember to move python-freethreading
into the newest Python array when we create formulae for a newer Python version.
yeah, I can imagine that would be popped up for py3.14 |
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?