Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kew: update formula to add macOS compatibility #196054

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ravachol
Copy link

@ravachol ravachol commented Oct 30, 2024

Removes unnecessary dependencies on Linux, FreeImage and FFmpeg.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@bevanjkay
Copy link
Member

Tests failed on all MacOS versions;

==> Testing kew
  ==> /opt/homebrew/Cellar/kew/3.0.0/bin/kew path /private/tmp/kew-test-20241030-24137-dt5plz
  mkdir: No such file or directory
  Error: kew: failed
  An exception occurred within a child process:
    BuildError: Failed executing: /opt/homebrew/Cellar/kew/3.0.0/bin/kew path /private/tmp/kew-test-20241030-24137-dt5plz

Removes unnecessary dependencies on Linux, FreeImage and FFmpeg.

kew: declare indirect deps with linkage

Signed-off-by: Rui Chen <[email protected]>
@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants