Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usbutils 018 #195376

Merged
merged 2 commits into from
Nov 2, 2024
Merged

usbutils 018 #195376

merged 2 commits into from
Nov 2, 2024

Conversation

chenrui333
Copy link
Member

Created by brew bump


Created with brew bump-formula-pr.

@github-actions github-actions bot added the bump-formula-pr PR was created using `brew bump-formula-pr` label Oct 23, 2024
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request autobump labels Oct 23, 2024
@chenrui333 chenrui333 removed the automerge-skip `brew pr-automerge` will skip this pull request label Oct 23, 2024
@chenrui333
Copy link
Member Author

need to move to meson build and update the patch

Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Oct 26, 2024
@chenrui333 chenrui333 added in progress Stale bot should stay away and removed stale No recent activity labels Oct 26, 2024
@carlocab
Copy link
Member

@nevack, do you mind taking a look at updating the patch? Thanks!

@nevack
Copy link
Contributor

nevack commented Oct 26, 2024

@nevack, do you mind taking a look at updating the patch? Thanks!

Yes, I've seen the release and already tried something locally to make it buildable again.

I can't commit for specific timespan to upload the patch, but I will ask upfront - do we need to submit a PR to upstream repo for the patch to be accepted here like previous time?

@nevack
Copy link
Contributor

nevack commented Oct 27, 2024

Submitted new patch
Homebrew/formula-patches#947

This formulae must be updated with meson to build usbutils.
I can do it separately.

Basically this would be something like.

$ meson setup _build --buildtype release
$ ninja -C _build lsusb usbhid-dump

@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Oct 27, 2024
@nevack
Copy link
Contributor

nevack commented Oct 27, 2024

@carlocab usbreset should not be built for macOS.

$ meson setup _build --buildtype release
$ ninja -C _build lsusb usbhid-dump

This is why I mentioned explicit ninja command, as meson builds all targets by default.

Should I adjust the patch to exclude usbreset target altogether or would you adjust build cmdline in this PR?

UPD: Same for usb-devices and lsusb.py - they should not be installed, as they depend on /sys/ FS.

@nevack
Copy link
Contributor

nevack commented Oct 27, 2024

Updated patch to not include unbuildable/unusable targets
Homebrew/formula-patches#948

@nevack
Copy link
Contributor

nevack commented Oct 28, 2024

@carlocab @chenrui333 Friendly ping

autobump: add usbutils

Signed-off-by: Rui Chen <[email protected]>

usbutils: update build patch

Co-authored-by: Rui Chen <[email protected]>
Co-authored-by: Dzmitry Neviadomski <[email protected]>
@chenrui333 chenrui333 added ready to merge PR can be merged once CI is green and removed automerge-skip `brew pr-automerge` will skip this pull request labels Nov 1, 2024
Copy link
Contributor

github-actions bot commented Nov 2, 2024

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Nov 2, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Nov 2, 2024
Merged via the queue into master with commit 243f8ec Nov 2, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the bump-usbutils-018 branch November 2, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autobump bump-formula-pr PR was created using `brew bump-formula-pr` CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. in progress Stale bot should stay away ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants