Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

g-l: Use language-specific heredoc delimiters for C code #195129

Merged
merged 107 commits into from
Oct 22, 2024

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Oct 21, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Carlo had the great idea to use language-specific heredoc delimiters rather than EOS. There's a RuboCop for this, but before we enable it for "EOS" we have to get rid of (the majority of?) the uses of EOS for non-caveats.

Here's a first pass at g* to l* formulae with C code inside heredocs because that was easily greppable.

@github-actions github-actions bot added the long dependent tests Set a long timeout for dependent testing label Oct 21, 2024
@issyl0 issyl0 removed long build Set a long timeout for formula testing CI-linux-self-hosted-deps Test dependents on Linux self-hosted runner long dependent tests Set a long timeout for dependent testing labels Oct 21, 2024
@issyl0 issyl0 force-pushed the g-l-switch-c-eos-heredocs-to-language-specific branch from 48d8180 to b5ff278 Compare October 21, 2024 23:14
@github-actions github-actions bot added long build Set a long timeout for formula testing CI-linux-self-hosted-deps Test dependents on Linux self-hosted runner long dependent tests Set a long timeout for dependent testing labels Oct 21, 2024
@chenrui333 chenrui333 added this pull request to the merge queue Oct 22, 2024
Merged via the queue into master with commit 8bde802 Oct 22, 2024
16 checks passed
@chenrui333 chenrui333 deleted the g-l-switch-c-eos-heredocs-to-language-specific branch October 22, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-linux-self-hosted-deps Test dependents on Linux self-hosted runner CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. long build Set a long timeout for formula testing long dependent tests Set a long timeout for dependent testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants