-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
a-f: Use language-specific heredoc delimiters for C code #195127
Merged
chenrui333
merged 93 commits into
master
from
a-f-switch-eos-code-blocks-to-language-specific
Oct 22, 2024
Merged
a-f: Use language-specific heredoc delimiters for C code #195127
chenrui333
merged 93 commits into
master
from
a-f-switch-eos-code-blocks-to-language-specific
Oct 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issyl0
added
the
CI-syntax-only
Change only affects brew syntax, not the install. Only run syntax CI.
label
Oct 21, 2024
github-actions
bot
added
CI-linux-self-hosted-deps
Test dependents on Linux self-hosted runner
long dependent tests
Set a long timeout for dependent testing
labels
Oct 21, 2024
issyl0
removed
CI-linux-self-hosted-deps
Test dependents on Linux self-hosted runner
long dependent tests
Set a long timeout for dependent testing
labels
Oct 21, 2024
issyl0
force-pushed
the
a-f-switch-eos-code-blocks-to-language-specific
branch
from
October 21, 2024 22:31
9817b03
to
f6f2529
Compare
github-actions
bot
added
CI-linux-self-hosted-deps
Test dependents on Linux self-hosted runner
long dependent tests
Set a long timeout for dependent testing
labels
Oct 21, 2024
issyl0
removed
CI-linux-self-hosted-deps
Test dependents on Linux self-hosted runner
long dependent tests
Set a long timeout for dependent testing
labels
Oct 21, 2024
chenrui333
approved these changes
Oct 22, 2024
chenrui333
deleted the
a-f-switch-eos-code-blocks-to-language-specific
branch
October 22, 2024 00:15
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?Carlo had the great idea to use language-specific heredoc delimiters rather than
EOS
. There's a RuboCop for this, but before we enable it for "EOS" we have to get rid of (the majority of?) the uses of EOS for non-caveats.Here's a first pass at a* to f* formulae with C code inside heredocs because that was easily
grep
pable.