Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tex-fmt 0.4.5 (new formula) #195005

Merged
merged 2 commits into from
Oct 21, 2024
Merged

tex-fmt 0.4.5 (new formula) #195005

merged 2 commits into from
Oct 21, 2024

Conversation

ivaquero
Copy link
Contributor

@ivaquero ivaquero commented Oct 20, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added new formula PR adds a new formula to Homebrew/homebrew-core rust Rust use is a significant feature of the PR or issue labels Oct 20, 2024
@ivaquero ivaquero force-pushed the add-tex-fmt branch 2 times, most recently from 6d1f4a1 to ed588c2 Compare October 20, 2024 15:43
@ivaquero
Copy link
Contributor Author

ivaquero commented Oct 20, 2024

Hi, @chenrui333 and @carlocab, I need your help.

I don't know how to correct the error in brew test, it seems that .write() function didn't work according to the output.

Error: brewforge/extras/tex-fmt: failed
An exception occurred within a child process:
  Minitest::Assertion: Expected /\\documentclass\{article\}\n\\title\{tex\-fmt\ Homebrew\ Test\}\n\\begin\{document\}\n\\maketitle\n\\begin\{itemize\}\n\ \ \\item\ Hello\n\ \ \\item\ World\n\\end\{itemize\}\n\\end\{document\}\n/ to match "".
/opt/homebrew/Library/Homebrew/vendor/bundle/ruby/3.3.0/gems/minitest-5.25.1/lib/minitest/assertions.rb:176:in `assert'
/opt/homebrew/Library/Homebrew/vendor/bundle/ruby/3.3.0/gems/minitest-5.25.1/lib/minitest/assertions.rb:291:in `assert_match'
/opt/homebrew/Library/Taps/brewforge/homebrew-extras/Formula/tex-fmt.rb:27:in `block in <class:TexFmt>'
/opt/homebrew/Library/Homebrew/formula.rb:2813:in `block (3 levels) in run_test'
/opt/homebrew/Library/Homebrew/extend/kernel.rb:536:in `with_env'
/opt/homebrew/Library/Homebrew/formula.rb:2812:in `block (2 levels) in run_test'
/opt/homebrew/Library/Homebrew/formula.rb:1199:in `with_logging'
/opt/homebrew/Library/Homebrew/formula.rb:2811:in `block in run_test'
/opt/homebrew/Library/Homebrew/mktemp.rb:75:in `block in run'
/opt/homebrew/Library/Homebrew/mktemp.rb:75:in `chdir'
/opt/homebrew/Library/Homebrew/mktemp.rb:75:in `run'
/opt/homebrew/Library/Homebrew/formula.rb:3129:in `mktemp'
/opt/homebrew/Library/Homebrew/formula.rb:2805:in `run_test'
/opt/homebrew/Library/Homebrew/test.rb:48:in `block in <main>'
/opt/homebrew/Library/Homebrew/vendor/portable-ruby/3.3.4_1/lib/ruby/3.3.0/timeout.rb:186:in `block in timeout'
/opt/homebrew/Library/Homebrew/vendor/portable-ruby/3.3.4_1/lib/ruby/3.3.0/timeout.rb:41:in `handle_timeout'
/opt/homebrew/Library/Homebrew/vendor/portable-ruby/3.3.4_1/lib/ruby/3.3.0/timeout.rb:195:in `timeout'
/opt/homebrew/Library/Homebrew/test.rb:52:in `<main>'

@chenrui333 chenrui333 added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Oct 21, 2024
Formula/t/tex-fmt.rb Outdated Show resolved Hide resolved
tex-fmt: update test

Signed-off-by: Rui Chen <[email protected]>
@chenrui333 chenrui333 added ready to merge PR can be merged once CI is green and removed CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Oct 21, 2024
@chenrui333
Copy link
Member

@ivaquero, thanks for your contribution to Homebrew! 🎉 🥇

Without awesome contributors like you, it would be impossible to maintain Homebrew to the high level of quality users have come to expect. Thank you!!!!

Copy link
Contributor

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Oct 21, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Oct 21, 2024
Merged via the queue into Homebrew:master with commit e356269 Oct 21, 2024
15 checks passed
@ivaquero ivaquero deleted the add-tex-fmt branch October 21, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. new formula PR adds a new formula to Homebrew/homebrew-core ready to merge PR can be merged once CI is green rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants