Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ansible@8: use resources for dependencies #193860

Merged
merged 2 commits into from
Nov 1, 2024
Merged

ansible@8: use resources for dependencies #193860

merged 2 commits into from
Nov 1, 2024
+152 −140

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Oct 11, 2024

This should help allow keeping ansible@8 installs working while we drop support for [email protected] in Python bindings.

@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Oct 11, 2024
@cho-m cho-m removed the automerge-skip `brew pr-automerge` will skip this pull request label Oct 11, 2024
@chenrui333
Copy link
Member

image

@cho-m cho-m force-pushed the ansible@8-bundle-py311-resources branch from c6d1580 to fda16a2 Compare October 11, 2024 23:29
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Oct 11, 2024
@cho-m cho-m force-pushed the ansible@8-bundle-py311-resources branch from fda16a2 to f0e4479 Compare October 12, 2024 01:12
@cho-m cho-m removed the automerge-skip `brew pr-automerge` will skip this pull request label Oct 12, 2024
@cho-m cho-m force-pushed the ansible@8-bundle-py311-resources branch from f0e4479 to 41c35a9 Compare October 12, 2024 01:39
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Oct 12, 2024
@cho-m cho-m marked this pull request as draft October 12, 2024 13:01
@cho-m cho-m force-pushed the ansible@8-bundle-py311-resources branch from 41c35a9 to 6b63a68 Compare November 1, 2024 13:43
@cho-m cho-m marked this pull request as ready for review November 1, 2024 13:43
@cho-m cho-m removed the automerge-skip `brew pr-automerge` will skip this pull request label Nov 1, 2024
p-linnane
p-linnane approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not crazy about the certifi change but it makes sense.

@cho-m
Copy link
Member Author

cho-m commented Nov 1, 2024

Not crazy about the certifi change but it makes sense.

I've been going back-and-forth on certifi. Specifically was experimenting with #193919 as an option.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Nov 1, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Nov 1, 2024
Merged via the queue into master with commit d4882e7 Nov 1, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the ansible@8-bundle-py311-resources branch November 1, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@p-linnane p-linnane p-linnane approved these changes

Assignees
No one assigned
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cho-m @chenrui333 @p-linnane @BrewTestBot