Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

icu4c@74 74.2 (new formula), icu4c@75: alias as icu4c and link on Linux #192986

Merged
merged 17 commits into from
Oct 29, 2024
Merged

icu4c@74 74.2 (new formula), icu4c@75: alias as icu4c and link on Linux #192986

merged 17 commits into from
Oct 29, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Oct 6, 2024 •
edited
Loading

This will be final step in #169239 to make all icu4c formulae versioned which may help bumps and avoid user complaints from deprecated formulae having broken linkage which we have to follow up on.

Need to finish up migrating as many other formulae beforehand. Blocked by:

@cho-m cho-m added the blocked label Oct 6, 2024
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request new formula PR adds a new formula to Homebrew/homebrew-core long dependent tests Set a long timeout for dependent testing labels Oct 6, 2024
@cho-m cho-m mentioned this pull request Oct 6, 2024
Merged
SMillerDev
SMillerDev previously approved these changes Oct 7, 2024
View reviewed changes
Base automatically changed from bump-icu4c-75.1 to master October 7, 2024 13:21
@BrewTestBot BrewTestBot dismissed SMillerDev’s stale review October 7, 2024 13:21

The base branch was changed.

@cho-m cho-m force-pushed the icu4c-alias branch 3 times, most recently from 6287f78 to 722c65d Compare October 8, 2024 02:10
@cho-m cho-m added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Oct 8, 2024
@cho-m cho-m force-pushed the icu4c-alias branch 2 times, most recently from 2259e08 to 2bfec7a Compare October 14, 2024 22:51
@cho-m cho-m mentioned this pull request Oct 22, 2024
Closed
6 tasks
@cho-m cho-m added the CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. label Oct 22, 2024
@cho-m cho-m removed blocked automerge-skip `brew pr-automerge` will skip this pull request labels Oct 25, 2024
@cho-m cho-m marked this pull request as ready for review October 25, 2024 14:05
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Oct 25, 2024
@cho-m cho-m added the CI-no-bottle-cache Disable bottle cache label Oct 25, 2024
@cho-m cho-m added the no long build conflict Do not allow merging other pull requests when files conflict with this one label Oct 25, 2024
@cho-m cho-m mentioned this pull request Oct 25, 2024
Merged
@cho-m cho-m added ready to merge PR can be merged once CI is green and removed automerge-skip `brew pr-automerge` will skip this pull request labels Oct 25, 2024
@cho-m cho-m requested a review from a team October 29, 2024 13:10
@github-actions GitHub Actions
Copy link
Contributor

:shipit: @cho-m has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Oct 29, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Oct 29, 2024
Merged via the queue into master with commit 8664490 Oct 29, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the icu4c-alias branch October 29, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlocab carlocab carlocab approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

@SMillerDev SMillerDev SMillerDev left review comments

Assignees
No one assigned
Labels
CI-no-bottle-cache Disable bottle cache CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. long dependent tests Set a long timeout for dependent testing new formula PR adds a new formula to Homebrew/homebrew-core no long build conflict Do not allow merging other pull requests when files conflict with this one ready to merge PR can be merged once CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cho-m @SMillerDev @carlocab @BrewTestBot