Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unxip 3.1 #192444

Merged
merged 2 commits into from
Nov 1, 2024
Merged

unxip 3.1 #192444

merged 2 commits into from
Nov 1, 2024

Conversation

timsutton
Copy link
Member

@timsutton timsutton commented Oct 1, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Oct 1, 2024
@timsutton timsutton marked this pull request as ready for review October 1, 2024 00:38
@timsutton timsutton removed the automerge-skip `brew pr-automerge` will skip this pull request label Oct 1, 2024
@timsutton
Copy link
Member Author

timsutton commented Oct 1, 2024

Now I realize that unxip 3.1 requires Swift 6.0 just to build. It's already configured with older macOS deployment targets but it does need a minimum of Xcode 16.0 (or CLT from Sequoia).

It seems to me like in order to bump this formula to 3.1, it could mean needing to require at least Sonoma as a minimum OS version since that'd be the oldest macOS which could still run Xcode 16? We might be able to instead build it with OSS Swift 6.0 if it's possible to install and build with the swift formula Ventura/Sonoma/Sequoia .

@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Oct 1, 2024
@chenrui333
Copy link
Member

since swift 6.0 is still in progress (#190921), mark the formula macos only

Formula/u/unxip.rb Outdated Show resolved Hide resolved
@carlocab carlocab marked this pull request as draft October 1, 2024 17:07
SMillerDev
SMillerDev previously approved these changes Oct 4, 2024
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Oct 26, 2024
@cho-m cho-m removed stale No recent activity autobump labels Oct 26, 2024
@carlocab carlocab changed the base branch from master to swift-fixes October 28, 2024 19:22
@carlocab carlocab removed the automerge-skip `brew pr-automerge` will skip this pull request label Oct 28, 2024
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Oct 28, 2024
Base automatically changed from swift-fixes to master October 28, 2024 19:41
@BrewTestBot BrewTestBot dismissed SMillerDev’s stale review October 28, 2024 19:41

The base branch was changed.

@carlocab carlocab marked this pull request as ready for review October 28, 2024 19:44
@carlocab carlocab removed the automerge-skip `brew pr-automerge` will skip this pull request label Oct 28, 2024
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Oct 28, 2024
@carlocab carlocab added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. and removed automerge-skip `brew pr-automerge` will skip this pull request labels Oct 28, 2024
@carlocab
Copy link
Member

Fails on macOS 13 and 14. macOS 13 isn't that surprising, but don't we have Xcode 16 on macOS 14?

@Bo98
Copy link
Member

Bo98 commented Oct 28, 2024

Likely uses macOS 15 SDK features (which macOS 14 has and Homebrew will use if you do depends_on xcode: ["16.0", :build]).

There's discussion above about improving that with depends_on swift: "6.0" in the future but for now it is how it works.

@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Nov 1, 2024
Copy link
Contributor

github-actions bot commented Nov 1, 2024

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Nov 1, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Nov 1, 2024
Merged via the queue into master with commit 42c1157 Nov 1, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the unxip-3.1 branch November 1, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autobump automerge-skip `brew pr-automerge` will skip this pull request CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants