Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove-disabled-packages: switch to create-pull-request action #190657

Merged
merged 1 commit into from
Sep 15, 2024

Conversation

carlocab
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Also, create an issue whenever this workflow fails.

Also, create an issue whenever this workflow fails.
@carlocab carlocab requested review from MikeMcQuaid and a team as code owners September 15, 2024 07:50
@github-actions github-actions bot added workflows PR modifies GitHub Actions workflow files automerge-skip `brew pr-automerge` will skip this pull request labels Sep 15, 2024
@carlocab carlocab added this pull request to the merge queue Sep 15, 2024
Merged via the queue into master with commit f956cb0 Sep 15, 2024
18 checks passed
@carlocab carlocab deleted the create-pull-request-1 branch September 15, 2024 11:01
@MikeMcQuaid
Copy link
Member

Thanks @carlocab!

Also, create an issue whenever this workflow fails.

Feature request for @carlocab @ZhongRuoyu @cho-m @Bo98 or whomever most cares: make this into an action we can use here, in the formulae.brew.sh scheduled workflow, in the Homebrew/brew release workflow and anywhere else we would find it useful to know about these failures (e.g. brew bump workflow?).

ZhongRuoyu added a commit to Homebrew/actions that referenced this pull request Sep 18, 2024
ZhongRuoyu added a commit to Homebrew/actions that referenced this pull request Sep 20, 2024
Related: Homebrew/homebrew-core#190657 (comment)

Co-authored-by: Sean Molenaar <[email protected]>

Co-authored-by: Mike McQuaid <[email protected]>
ZhongRuoyu added a commit to Homebrew/actions that referenced this pull request Sep 20, 2024
ZhongRuoyu added a commit to Homebrew/actions that referenced this pull request Sep 20, 2024
Related: Homebrew/homebrew-core#190657 (comment)

Co-authored-by: Sean Molenaar <[email protected]>
Co-authored-by: Mike McQuaid <[email protected]>
Co-authored-by: Bo Anderson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip `brew pr-automerge` will skip this pull request workflows PR modifies GitHub Actions workflow files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants