Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: set type: number where applicable #181647

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Conversation

carlocab
Copy link
Member

Inputs seem to support type: number now1, so we should use them
where we can to improve the type-safety of these workflows and to
minimise our exposure to workflow injection.

Footnotes

  1. https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/accessing-contextual-information-about-workflow-runs#inputs-context

Inputs seem to support `type: number` now[^1], so we should use them
where we can to improve the type-safety of these workflows and to
minimise our exposure to workflow injection.

[^1]: https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/accessing-contextual-information-about-workflow-runs#inputs-context
@carlocab carlocab requested review from MikeMcQuaid and a team as code owners August 19, 2024 07:07
@github-actions github-actions bot added workflows PR modifies GitHub Actions workflow files automerge-skip `brew pr-automerge` will skip this pull request labels Aug 19, 2024
Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

@carlocab carlocab added this pull request to the merge queue Aug 19, 2024
Merged via the queue into master with commit 5df62bb Aug 19, 2024
19 of 20 checks passed
@carlocab carlocab deleted the workflow-input-types branch August 19, 2024 07:35
Copy link
Contributor

@carlocab bottle request for hello failed.

@carlocab
Copy link
Member Author

@carlocab bottle request for hello failed.

Yep, workflow seems to work. This should be good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip `brew pr-automerge` will skip this pull request workflows PR modifies GitHub Actions workflow files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants