Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows/triage: long build allow dot in versioned name #178611

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Jul 26, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

e.g. [email protected] - #178587

long build is likely needed for alternate versions of a formula (unless there was a significant refactor between versions).


On side note, long dependent tests is probably not needed on all versions as it is rare that multiple versions all have high number of dependents. So may want to selectively enable rather than:

@cho-m cho-m requested review from MikeMcQuaid and a team as code owners July 26, 2024 19:56
@github-actions github-actions bot added workflows PR modifies GitHub Actions workflow files automerge-skip `brew pr-automerge` will skip this pull request labels Jul 26, 2024
@p-linnane p-linnane added this pull request to the merge queue Jul 26, 2024
Merged via the queue into master with commit a745fc5 Jul 26, 2024
18 checks passed
@p-linnane p-linnane deleted the triage-long-build-minor-version branch July 26, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip `brew pr-automerge` will skip this pull request workflows PR modifies GitHub Actions workflow files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants